-
Notifications
You must be signed in to change notification settings - Fork 28
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bugfix: PDF variation indices. #178
base: 106X_HH_UL
Are you sure you want to change the base?
Conversation
Are all samples affected or could we do a partial production? If the former we might as well fic AK8 JECs before starting |
Only samples associated to the three modified schemes are affected, but we are talking about many. I would fix any pending issue before proceeding with resubmission. |
I agree with Bruno. |
b35cd49
to
ce84927
Compare
The latest commit fixes the issue reported here, which highlights a bug in the LHE weights of the |
Added parser to
The current solution is however acceptable, I believe. |
The latest fix addresses this issue, where I have tested locally a single sample for each scheme, but I cannot guarantee there is no corner case where this code fails. Please review. |
I was using the wrong starting indices for some of the systematic variation schemes. The impact is very significant.
In particular, the
MadGraph45B
scheme is accessing vector elements that do not exist, which might explain the "outliers" that have been observed.The bug comes from a confusion between "LHE weight id" and the actual vector index of the LHE weights, which are sometimes aligned, but can be wildly different.
Big ntuples will unfortunately have to be reproduced.